Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start of node compatible socket interface #1097

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

sjoerdvisscher
Copy link
Contributor

@sjoerdvisscher sjoerdvisscher commented Jul 17, 2023

This is a work in progress, but I want to merge this since the change otherwise wont survive the move to a new repo.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Formatting, PNG optimization, etc. are updated
    • Important changes are reflected in changelog.d of the affected packages
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reference the ADR in the PR and reference the PR in the ADR (if revelant)
    • Reviewer requested

@sjoerdvisscher sjoerdvisscher force-pushed the sv/node-compatible-socket-interface branch from 2fcb290 to 5cdfe61 Compare July 18, 2023 14:34
@sjoerdvisscher sjoerdvisscher marked this pull request as ready for review July 18, 2023 14:36
@koslambrou koslambrou merged commit 331033d into main Jul 24, 2023
1 check passed
@koslambrou koslambrou deleted the sv/node-compatible-socket-interface branch July 24, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants