cardano-testnet: QoL changes #6008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smelc
changed the title
smelc
force-pushed
the
smelc/testnet-honor-nodes-custom-params
branch
from
5a845ea
to
b87724e
Compare
9 tasks
Jimbo4350
reviewed
Oct 10, 2024
| @@ -65,7 +65,7 @@ pCardanoTestnetCliOptions envCli = CardanoTestnetOptions | |||
| pNumSpoNodes :: Parser [TestnetNodeOptions] | |||
| pNumSpoNodes = | |||
| OA.option | |||
| ((`L.replicate` SpoTestnetNodeOptions Nothing []) <$> auto) | |||
| ((`L.replicate` TestnetNodeOptions Nothing []) <$> auto) | |||
There was a problem hiding this comment.
We should keep the differentiation between SPOs and relays.
Base automatically changed from
smelc/testnet-remove-unused-datatype
to
master
October 11, 2024 08:54
|
The point of this PR was actually implemented in #6007, so this one becomes mostly empty. |
smelc
force-pushed
the
smelc/testnet-honor-nodes-custom-params
branch
2 times, most recently
from
e0b10a1
to
0f46d78
Compare
smelc
changed the title
carbolymer
approved these changes
Oct 14, 2024
Jimbo4350
approved these changes
Oct 14, 2024
| @@ -65,6 +65,8 @@ pCardanoTestnetCliOptions envCli = CardanoTestnetOptions | |||
|
|
|||
| pNumSpoNodes :: Parser [TestnetNodeOptions] | |||
| pNumSpoNodes = | |||
| -- We don't support passing custom node configurations files on the CLI. | |||
| @@ -144,7 +144,7 @@ getDefaultShelleyGenesis asbe maxSupply opts = do | |||
| -- > │ └── README.md | |||
| -- > ├── drep-keys | |||
| -- > │ ├── drep{1,2,3} | |||
| -- > │ │ └── drep.{skey,drep.vkey} | |||
| -- > │ │ └── drep.{skey,vkey} | |||
There was a problem hiding this comment.
How did you notice to change this?
There was a problem hiding this comment.
It's @carbolymer who did this change, I think after seeing my (late) review on #6007 😉
smelc
force-pushed
the
smelc/testnet-honor-nodes-custom-params
branch
from
2c8a630
to
7478ef1
Compare
smelc
force-pushed
the
smelc/testnet-honor-nodes-custom-params
branch
from
7478ef1
to
37fcfaa
Compare
smelc
force-pushed
the
smelc/testnet-honor-nodes-custom-params
branch
from
37fcfaa
to
31cd564
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[edit] QoL improvements, because most of this PR's content has been concurrently implemented in #6007