Update cardano-node after addition of the new BulkSync implementation #5942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facundominguez
force-pushed
the
blockfetch/milestone-1
branch
from
c76fc4f
to
d523ca1
Compare
only temporary for testing (remove this commit once we rebased on top of 9.1.1/9.2.0)
Jimbo4350
reviewed
Sep 9, 2024
| @@ -280,6 +280,7 @@ defaultYamlHardforkViaConfig era = | |||
| , (proxyName (Proxy @TraceBlockFetchProtocolSerialised), Aeson.Bool False) | |||
| , (proxyName (Proxy @TraceBlockFetchServer), Aeson.Bool False) | |||
| , (proxyName (Proxy @TraceBlockchainTime), Aeson.Bool True) | |||
| , (proxyName (Proxy @TraceChainSyncJumping), Aeson.Bool False) | |||
There was a problem hiding this comment.
To keep with the ordering, this should be under TraceChainSyncHeaderServer.
| @@ -329,7 +332,8 @@ instance FromJSON PartialNodeConfiguration where | |||
|
|
|||
| -- Genesis syncing protocol | |||
| -- DISABLED BY DEFAULT | |||
| pncEnableGenesis <- Last <$> v .:? "EnableGenesis" .!= Just False | |||
| pncEnableGenesis <- Last <$> v .:? "EnableGenesis" .!= Just False | |||
There was a problem hiding this comment.
Why two configuration values? If the genesis config plans aren't present then we know to not enable it.
There was a problem hiding this comment.
Thanks, what would you prefer instead? Something like
Genesis:
Enable: True
# optionally
LowLevelOptions:
....?
- Move most info to higher verbosity/detail level (to avoid spamming the logs) - Use structured logging instead of `Show` instances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates tracing and exposes the genesis configuration.
It requires IntersectMBO/ouroboros-consensus#1179.
cabal.projectis made to point to a back-port of the BulkSync implementation onouroboros-network-0.16.1.1andouroboros-consensus-0.20.0.0.