Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MANIFEST.in #1450

Merged
merged 1 commit into from
May 6, 2024
Merged

Remove MANIFEST.in #1450

merged 1 commit into from
May 6, 2024

Conversation

ZzEeKkAa
Copy link
Collaborator

@ZzEeKkAa ZzEeKkAa commented May 6, 2024

Reverts #1447 and fixes root cause of the problem: Manifest was setup incorrectly, that resulted wheel to install some artifacts in the root directory. It is no longer required as it managed through the setuptools configuration directly.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@AndresGuzman-Ballen
Copy link
Contributor

Whoops! My bad :(

Don't forget to remove the changes from bld.bat too :)

@coveralls
Copy link
Collaborator

coveralls commented May 6, 2024

Coverage Status

coverage: 86.494% (+0.01%) from 86.48%
when pulling e42a8da on fix/manifest
into 431dff7 on main.

@ZzEeKkAa
Copy link
Collaborator Author

ZzEeKkAa commented May 6, 2024

Looks like it is not that simple..

@ZzEeKkAa ZzEeKkAa merged commit 84acdea into main May 6, 2024
58 of 70 checks passed
@ZzEeKkAa ZzEeKkAa deleted the fix/manifest branch May 6, 2024 20:34
github-actions bot added a commit that referenced this pull request May 6, 2024
github-actions bot added a commit to adarshyoga/numba-dpex that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants