Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve pyproject.toml #1449

Merged
merged 1 commit into from
May 3, 2024
Merged

Improve pyproject.toml #1449

merged 1 commit into from
May 3, 2024

Conversation

ZzEeKkAa
Copy link
Collaborator

@ZzEeKkAa ZzEeKkAa commented May 2, 2024 •
edited
Loading

Load build requirements from pyproject during conda build.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa force-pushed the feature/improve_pyproject_toml branch from 59d33e7 to bf6566c Compare May 2, 2024 19:25
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review May 2, 2024 19:28
@ZzEeKkAa ZzEeKkAa requested a review from diptorupd May 2, 2024 19:29
@coveralls
Copy link
Collaborator

coveralls commented May 2, 2024 •
edited
Loading

Coverage Status

coverage: 86.48%. remained the same
when pulling 048b1f1 on feature/improve_pyproject_toml
into 50cd1c5 on main.

@diptorupd diptorupd force-pushed the feature/improve_pyproject_toml branch from bf6566c to 048b1f1 Compare May 3, 2024 17:19
diptorupd
diptorupd approved these changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@diptorupd diptorupd enabled auto-merge May 3, 2024 17:24
@diptorupd diptorupd merged commit 431dff7 into main May 3, 2024
54 of 69 checks passed
@diptorupd diptorupd deleted the feature/improve_pyproject_toml branch May 3, 2024 17:49
github-actions bot added a commit that referenced this pull request May 3, 2024
@github-actions
Merge pull request #1449 from IntelPython/feature/improve_pyproject_toml
aa44524 
Improve pyproject.toml 431dff7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

@oleksandr-pavlyk oleksandr-pavlyk Awaiting requested review from oleksandr-pavlyk oleksandr-pavlyk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZzEeKkAa @coveralls @diptorupd