Simplify DpnpNdArray to USMNdArray conversion during kernel argument resolution. #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diptorupd
force-pushed
the
fix/kernel_resolve_dpnp_args
branch
from
d8690d8
to
6916a9b
Compare
diptorupd
force-pushed
the
fix/kernel_resolve_dpnp_args
branch
from
6916a9b
to
583dd5b
Compare
github-actions bot
added a commit
that referenced
this pull request
Jul 19, 2023
Simplify DpnpNdArray to USMNdArray conversion during kernel argument resolution. 1bb30da
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you provided a meaningful PR description?
In KernelTarget's
resolve_argument_typewe convertDpnpNdArraytype arguments toUSMNdArray. Previously, the conversion was done using the__sycl_usm_array_interface__via Python. The PR changes to only do a type conversion fromDpnpNdArraytoUSMNdArraywithout having to introspect the__sycl_usm_array_interface__dictionary.Have you added a test, reproducer or referred to an issue with a reproducer?
Not needed as existing tests check for the functionality.