Skip to content

Commit

Permalink
Remove unused parfor kernel IR methods
Browse files Browse the repository at this point in the history
  • Loading branch information
ZzEeKkAa committed Apr 29, 2024
1 parent 8f8b98c commit 5712ef4
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 62 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,6 @@ def _generate_kernel_ir(self):
def dump_kernel_string(self):
raise NotImplementedError

@abc.abstractmethod
def dump_kernel_ir(self):
raise NotImplementedError

@property
@abc.abstractmethod
def kernel_ir(self):
raise NotImplementedError

@property
@abc.abstractmethod
def kernel_string(self):
Expand Down
18 changes: 2 additions & 16 deletions numba_dpex/core/parfors/kernel_templates/range_kernel_template.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def __init__(
self._param_dict = param_dict

self._kernel_txt = self._generate_kernel_stub_as_string()
self._py_func, self._kernel_ir = self._generate_kernel_ir()
self._py_func = self._generate_kernel_ir()

def _generate_kernel_stub_as_string(self):
"""Generates a stub dpex kernel for the parfor as a string.
Expand Down Expand Up @@ -108,17 +108,7 @@ def _generate_kernel_ir(self):
globls = {"dpnp": dpnp, "dpex": dpex}
locls = {}
exec(self._kernel_txt, globls, locls)
kernel_fn = locls[self._kernel_name]

return kernel_fn, None

@property
def kernel_ir(self):
"""Returns the Numba IR generated for a RangeKernelTemplate.
Returns: The Numba functionIR object for the compiled kernel_txt string.
"""
return self._kernel_ir
return locls[self._kernel_name]

@property
def kernel_string(self):
Expand All @@ -133,7 +123,3 @@ def dump_kernel_string(self):
"""Helper to print the kernel function string."""
print(self._kernel_txt)
sys.stdout.flush()

def dump_kernel_ir(self):
"""Helper to dump the Numba IR for the RangeKernelTemplate."""
self._kernel_ir.dump()
41 changes: 4 additions & 37 deletions numba_dpex/core/parfors/kernel_templates/reduction_template.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def __init__(
self._typemap = typemap

self._kernel_txt = self._generate_kernel_stub_as_string()
self._py_func, self._kernel_ir = self._generate_kernel_ir()
self._py_func = self._generate_kernel_ir()

def _generate_kernel_stub_as_string(self):
"""Generate reduction main kernel template"""
Expand Down Expand Up @@ -160,18 +160,7 @@ def _generate_kernel_ir(self):
globls = {"dpnp": dpnp, "kapi": kapi}
locls = {}
exec(self._kernel_txt, globls, locls)
kernel_fn = locls[self._kernel_name]

return kernel_fn, None

@property
def kernel_ir(self):
"""Returns the Numba IR generated for a
TreeReduceIntermediateKernelTemplate.
Returns: The Numba functionIR object for the compiled kernel_txt string.
"""
return self._kernel_ir
return locls[self._kernel_name]

@property
def kernel_string(self):
Expand All @@ -189,11 +178,6 @@ def dump_kernel_string(self):
print(self._kernel_txt)
sys.stdout.flush()

def dump_kernel_ir(self):
"""Helper to dump the Numba IR for a
TreeReduceIntermediateKernelTemplate."""
self._kernel_ir.dump()


class RemainderReduceIntermediateKernelTemplate(KernelTemplateInterface):
"""The class to build reduction remainder kernel_txt template and
Expand Down Expand Up @@ -233,7 +217,7 @@ def __init__(
self._reductionKernelVar = reductionKernelVar

self._kernel_txt = self._generate_kernel_stub_as_string()
self._py_func, self._kernel_ir = self._generate_kernel_ir()
self._py_func = self._generate_kernel_ir()

def _generate_kernel_stub_as_string(self):
"""Generate reduction remainder kernel template"""
Expand Down Expand Up @@ -319,18 +303,7 @@ def _generate_kernel_ir(self):
globls = {"dpnp": dpnp, "kapi": kapi}
locls = {}
exec(self._kernel_txt, globls, locls)
kernel_fn = locls[self._kernel_name]

return kernel_fn, None

@property
def kernel_ir(self):
"""Returns the Numba IR generated for a
RemainderReduceIntermediateKernelTemplate.
Returns: The Numba functionIR object for the compiled kernel_txt string.
"""
return self._kernel_ir
return locls[self._kernel_name]

@property
def kernel_string(self):
Expand All @@ -348,9 +321,3 @@ def dump_kernel_string(self):

print(self._kernel_txt)
sys.stdout.flush()

def dump_kernel_ir(self):
"""Helper to dump the Numba IR for the
RemainderReduceIntermediateKernelTemplate."""

self._kernel_ir.dump()

0 comments on commit 5712ef4

Please sign in to comment.