Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] 공간에 대한 아티클 조회 기능을 구현한다. #52

Merged
merged 6 commits into from
Jul 14, 2023

Conversation

Jin409
Copy link
Collaborator

@Jin409 Jin409 commented Jul 13, 2023

@Jin409 Jin409 changed the base branch from develop to feature/#49 July 13, 2023 13:09
@Jin409 Jin409 requested a review from sunseo18 July 13, 2023 13:09
@Jin409 Jin409 self-assigned this Jul 13, 2023
Copy link
Collaborator

@sunseo18 sunseo18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최고당 ₩!~!

Comment on lines 54 to 55
() -> new NotFoundException(Error.NOT_FOUND_SPACE_OF_ARTICLE_EXCEPTION,
Error.NOT_FOUND_SPACE_OF_ARTICLE_EXCEPTION.getMessage()));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사소한 거긴 한데,,
공간에 대한 아티클이면
NOT_FOUND_ARTICLE_OF_SPACE_EXCEPTION 이 의미적으로 더 맞지 않을까요!?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

화긴~!

@sunseo18 sunseo18 merged commit 451ad58 into feature/#49 Jul 14, 2023
@sunseo18 sunseo18 deleted the feature/#51 branch July 14, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 공간에 대한 아티클 조회 API (/space/{spaceId}/article) 를 구현한다.
2 participants