Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typescript node #103

Merged
merged 4 commits into from
Jun 21, 2024
Merged

Update typescript node #103

merged 4 commits into from
Jun 21, 2024

Conversation

egrace479
Copy link
Member

match typechecking node version to dockerfile

match typechecking node version to dockerfile
@egrace479 egrace479 added the dependencies Pull requests that update a dependency file label Jun 21, 2024
@johnbradley
Copy link
Collaborator

I'm also getting the error the automated tests hit:

rm -rf node_modules
npm install

Output:

npm ERR! code ETARGET
npm ERR! notarget No matching version found for @types/node@18.20.3.
npm ERR! notarget In most cases you or one of your dependencies are requesting

Perhaps this package doesn't follow the nodejs releases that closely.

requires newer setup-node action
@johnbradley
Copy link
Collaborator

Looks like 18.19.38 is the most recent in the 18.x series: https://www.npmjs.com/package/@types/node?activeTab=versions

typescript layer on node has different versioning
@johnbradley
Copy link
Collaborator

Could you update package-lock.json as well?

"@types/node": "18.15.12",

I think you can just do npm install and it will sort it out.

@egrace479 egrace479 changed the title Update to node 18.20.3 Update typescript node Jun 21, 2024
Copy link
Collaborator

@johnbradley johnbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@egrace479 egrace479 merged commit 43d5bef into main Jun 21, 2024
2 checks passed
@egrace479 egrace479 deleted the node-update branch June 21, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants