Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(*): switch to control flow blocks #14864

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

damyanpetev
Copy link
Member

@damyanpetev damyanpetev commented Oct 2, 2024

Closes #

Some changes are manual since the migration didn't detect all uses. Also note that I've manually adjusted the default formatting the ng migration does (worse if it doesn't format), but that was far from error-free and I've corrected the more egregious mishaps or redundant changes. Not perfect yet and will be looking into a formatting tool to enforce since the default VS Code formatting doesn't handle these yet microsoft/vscode-html-languageservice#177.

Also there are an alarming number of warnings for the track handling that's migrated 1:1 from the old behavior, so there's extra reporting now and we should invest some time to track these down.

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant