-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tabs): implement manual and auto activation modes for keyboard navigation - master #14858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgianastasov
added
❌ status: awaiting-test
PRs awaiting manual verification
tabs
keyboard-navigation
version: 18.2.x
labels
Oct 1, 2024
…into ganastasov/feat-14839-master
@georgianastasov , @kacheshmarova , can anyone from your team validate this? We are trying to close 18.2 and if this doesn't get in master in a few days tops it's going to be left for 19.x |
gedinakova
requested changes
Oct 18, 2024
projects/igniteui-angular/src/lib/tabs/tabs/tabs.component.spec.ts
Outdated
Show resolved
Hide resolved
gedinakova
previously approved these changes
Oct 18, 2024
RivaIvanova
added
💥 status: in-test
PRs currently being tested
and removed
❌ status: awaiting-test
PRs awaiting manual verification
labels
Oct 18, 2024
RivaIvanova
added
🛠️ status: in-development
Issues and PRs with active development on them
and removed
💥 status: in-test
PRs currently being tested
labels
Oct 18, 2024
georgianastasov
added
❌ status: awaiting-test
PRs awaiting manual verification
and removed
🛠️ status: in-development
Issues and PRs with active development on them
labels
Oct 18, 2024
RivaIvanova
added
💥 status: in-test
PRs currently being tested
and removed
❌ status: awaiting-test
PRs awaiting manual verification
labels
Oct 18, 2024
RivaIvanova
added
✅ status: verified
Applies to PRs that have passed manual verification
and removed
💥 status: in-test
PRs currently being tested
labels
Oct 18, 2024
gedinakova
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
keyboard-navigation
tabs
version: 18.2.x
✅ status: verified
Applies to PRs that have passed manual verification
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14839
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes (migrations guidelines)