Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 5: controller specs #5

Merged
merged 6 commits into from
Dec 5, 2023
Merged

Conversation

ITurres
Copy link
Owner

@ITurres ITurres commented Dec 5, 2023

🚩I have made the following changes to complete Milestone 5

Here is a summary of what has been done

Type of files changed/added

My Skills

In this new Branch, I have βž•ADDEDβž• the succeeding *πŸ“‚ folders and/or **πŸ“„ files to complete this milestone requirements

*πŸ“‚ root/

  • *πŸ“‚ spec/

    • *πŸ“‚ factories/

      • **πŸ“„ comments_factory.rb βž•

      • **πŸ“„ likes_factory.rb βž•

      • **πŸ“„ posts_factory.rb βž•

      • **πŸ“„ users_factory.rb βž•

        • These are the factories for the models.
    • *πŸ“‚ requests/

      • **πŸ“„ posts_controller_spec.rb βž•

      • **πŸ“„ users_controller_spec.rb βž•

        • For index and show actions, I added the tests for the PostsController and UsersController.
          • Make sure to test:
            • If response status was correct.
            • If a correct template was rendered.
            • If the response body includes correct placeholder text.

I have ✏️MODIFIED✏️ the succeeding *πŸ“‚ folders and/or πŸ“„** files

*πŸ“‚ root/

  • **πŸ“„ README.md ✏️

    • I checked as completed the controllers specs task.
  • **πŸ“„ Gemfile ✏️

  • **πŸ“„ Gemfile.lock ✏️

    • I have added the following gems:

      • rails-controller-testing
      • factory_bot_rails
      • shoulda-matchers
    • *πŸ“‚ spec/

      • **πŸ“„rails_helper.rb ✏️

      • **πŸ“„spec_helper.rb ✏️

        • This files have been updated with the new required gems.

Thank you for taking the time to review this PR ⭐


If you need additional information or have any questions, please don't hesitate to contact me on Slack as Arturo (Arthur) Emanuel Guerra Iturres. I'll be happy to help you out. 🎯


- 'factory_bot_rails' for factories.
- 'rails-controller-testing' for controller specs.
- 'shoulda-matchers' for model specs.
- Add 'comments_factory'.
- Add 'likes_factory'.
- Add 'posts_factory'.
- Add 'users_factory'.
@ITurres ITurres added documentation Improvements or additions to documentation enhancement New feature or request tests RSpec Tests labels Dec 5, 2023
@ITurres ITurres self-assigned this Dec 5, 2023
Copy link

@mikethreels mikethreels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Arthur,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! πŸŽ‰

Highlights

  • Good job writing the tests

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@ITurres
Copy link
Owner Author

ITurres commented Dec 5, 2023

Hi @mikethreels Mike! how are you? long time no see! Thank you for having reviewed my PR! 🎯, I wish you a great day and happy programming 🀠 πŸ₯‚

@ITurres ITurres merged commit 4bab75c into development Dec 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request tests RSpec Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants