Require Julia 1.10, fix tests for Julia 1.11 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6.
The issue was that the vertex positions of the images are being generated using NetworkLayout.jl, which starts with random vertex positions and then performs an optimization. However, the Julia random number generator can change between Julia versions, which it did between Julia 1.10 to 1.11, so the positions generated by NetworkLayout.jl are different between those versions. The strategy I took here is to have different sets of reference images for different Julia versions, which isn't ideal since then they have to be regenerated when a new Julia version is released (maybe that can be automated but that sounds a bit annoying to set up). An alternative would be to use StableRNGs.jl to generate random starting positions that won't depend on the Julia version, however that will require this PR in NetworkLayout.jl: JuliaGraphs/NetworkLayout.jl#65.
See also MakieOrg/GraphMakie.jl#190.