Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use lunchpail needs to install minio #414

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aavarghese
Copy link
Member

No description provided.

Copy link
Member

@starpit starpit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aavarghese
Copy link
Member Author

Need to find out why these tests are failing with Error: exit status 1. None of these tests fail locally on macos so will have to reproduce GHA like ubuntu env...

@starpit
Copy link
Member

starpit commented Oct 11, 2024

why did we change the wget install of minio to one that is debian-specific? and also one that (by use of apt) requires root access?

Copy link
Member

@starpit starpit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did we change the wget install of minio to one that is debian-specific? and also one that (by use of apt) requires root access?

Signed-off-by: aavarghese <avarghese@us.ibm.com>
@aavarghese
Copy link
Member Author

why did we change the wget install of minio to one that is debian-specific? and also one that (by use of apt) requires root access?

I was seeing wget command not found error exit status 1 in some cases...

@starpit
Copy link
Member

starpit commented Oct 12, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants