feat: add interceptor for error responses #1646
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Add interceptor for error response augmentation
Fixes: s1003
PR Checklist
Please make sure that your PR fulfills the following requirements:
Angular Commit Message Guidelines.
PR Type
What is the current behavior?
Cloudant/CouchDB error models are handled by the core with only the
error
field being processed. Obtaining e.g. thereason
field requires additional user code.What is the new behavior?
The error response is augmented with
errors
andtrace
properties.This improves the way the core handles the error response and enhances the user facing exception string to include the
reason
.The
trace
is the CouchDB request ID which can be used to correlate with logs.Does this PR introduce a breaking change?
The existing error model fields are retained, the new fields are backwards compatible.
Other information
Add
errorResponseInterceptor
.Modify
cloudantBaseService
to apply interceptor.New tests in
errorResponseInterceptorTest
.Fix service options on
test/unit/features/testDataProviders.js
.Add
nock
for testing.