Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tabiew 0.7.0 #194938

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

tabiew 0.7.0 #194938

wants to merge 3 commits into from

Conversation

shshemi
Copy link
Contributor

@shshemi shshemi commented Oct 19, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added rust Rust use is a significant feature of the PR or issue automerge-skip `brew pr-automerge` will skip this pull request labels Oct 19, 2024
@chenrui333
Copy link
Member

  ==> Testing tabiew
  Killing child processes...
  
  Session terminated, killing shell...::error::tabiew: failed
  An exception occurred within a child process:
    Minitest::Assertion: Expected /you\ think\?/ to match "".

also please use rebase rather than merge commit to refresh the PR.

@shshemi
Copy link
Contributor Author

shshemi commented Oct 19, 2024

Hey @gromgit,
Would you kindly help me with the error?

@gromgit
Copy link
Member

gromgit commented Oct 19, 2024

Try adding input.close after the input.puts ":q" line.

@shshemi
Copy link
Contributor Author

shshemi commented Oct 19, 2024

@gromgit
The test still fails on my local machine with this error:

Session terminated, killing shell...Error: tabiew: failed
An exception occurred within a child process:
  Minitest::Assertion: Expected /you\ think\?/ to match "".

Interestingly, I tried version 0.6.2, and that one failed as well!

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. and removed automerge-skip `brew pr-automerge` will skip this pull request labels Oct 19, 2024
@shshemi
Copy link
Contributor Author

shshemi commented Oct 19, 2024

@chenrui333
The problems seem to be resolved. Please review the pull request again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosquash Automatically squash pull request commits according to Homebrew style. rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants