[#1626] fix comment field resizing #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fey
reviewed
Jun 17, 2024
| @@ -9,7 +9,7 @@ | |||
| {{ html()->hidden('commentable_type')->value(get_class($model)) }} | |||
| {{ html()->hidden('commentable_id')->value($model->id) }} | |||
| <div class="form-floating"> | |||
| {{ html()->textarea('content')->class('form-control h-100')->required() }} | |||
| {{ html()->textarea('content')->class('form-control')->attribute('style', 'height: 100%')->required() }} | |||
There was a problem hiding this comment.
@Smol-An мы стараемся не использовать inline атрибуты стилей.
Посмотрите, пожалуйста, есть ли в bootstrap похожий css-класс, чтобы им воспользоваться. Если нет, то можно использовать SCSS и создать кастомный класс (в ридми посмотрите, вроде был про это пункт, как именовать такие кастомные клкссы)
Smol-An
force-pushed
the
fix_comment_field
branch
from
a69ecb3
to
3d08364
Compare
fey
reviewed
Jun 20, 2024
amshkv
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request details
A change has been made to the comment form component so that the field can be expanded vertically.
Issues fixed
issue #1626