Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix home page adaptive #1595

Merged
merged 4 commits into from
Oct 24, 2023
Merged

Fix home page adaptive #1595

merged 4 commits into from
Oct 24, 2023

Conversation

asselzhl
Copy link
Contributor

@asselzhl asselzhl commented Oct 3, 2023 •
edited
Loading

Pull request details

Fixed bootstrap classes to get an adaptive page for small screens.

Issues fixed

#1448

Link to demo

https://asselzhl-sicp.onrender.com

@asselzhl
Copy link
Contributor Author

asselzhl commented Oct 6, 2023

@fey
Взгляните, пожалуйста🙌🏻

@fey
Copy link
Collaborator

fey commented Oct 6, 2023

@asselzhl я попозжа гляну, когда из отпуска вернусь (16 октября), пока можете другие задачки поделать <3

@sgmdlt
Copy link
Contributor

sgmdlt commented Oct 17, 2023

@fey

@fey
Copy link
Collaborator

fey commented Oct 17, 2023

@asselzhl
Добрый день. Попросил @HelenOne глянуть ПР.
Может быть у вас получится задеплоить демку на render?

@asselzhl
Copy link
Contributor Author

asselzhl commented Oct 18, 2023 •
edited
Loading

здравствуйте, у меня не получилось задеплоить, выдает ошибку
@fey

@fey
Copy link
Collaborator

fey commented Oct 18, 2023

@asselzhl а можете скриншот ошибки или выложить логи ошибки например на pastebin.com?

@asselzhl
Copy link
Contributor Author

@fey
image

@fey
Copy link
Collaborator

fey commented Oct 18, 2023

сообщение говорит о том, что не может подключиться к БД, возможно не установлены требуемые переменны окружения.
https://github.com/Hexlet/hexlet-sicp/wiki/How-to-deploy-demo-to-render попробуйте пройтись по этой инструкции.
Если будут вопросы, то создайте топик в Discussions https://github.com/Hexlet/hexlet-sicp/discussions

@asselzhl
Copy link
Contributor Author

@fey
получилось, вот ссылка:
https://asselzhl-sicp.onrender.com

@fey fey requested a review from HelenOne October 18, 2023 14:36
@ola-9
Copy link

ola-9 commented Oct 23, 2023

@HelenOne

@HelenOne HelenOne merged commit 7ec6ce4 into Hexlet:main Oct 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fey fey fey approved these changes

@HelenOne HelenOne HelenOne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@asselzhl @fey @sgmdlt @ola-9 @HelenOne