add <Footer /> component #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this Pull Request originated from a forked repository, Now cannot deploy it as there are potential security risks. If you are a collaborator on this repository, consider making this Pull Request from a branch on the same repository instead of a fork. |
0x48piraj
suggested changes
Jul 8, 2018
bogas04
requested changes
Jul 9, 2018
| <link | ||
| rel="stylesheet" | ||
| href="http://maxcdn.bootstrapcdn.com/font-awesome/4.2.0/css/font-awesome.min.css" | ||
| /> |
There was a problem hiding this comment.
Could you please remove fonts and external CSS? Thank you so much!
| Advancement by Youth), was established in May 2010 by a group of | ||
| young engineers from IITs and NITs. | ||
| </p> | ||
|
|
There was a problem hiding this comment.
Would it be possible to break the Footer component into smaller components? Anything beyond 150 lines of code seems excessive enough to read.
There was a problem hiding this comment.
ok, working on it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a basic version. Further changes will be made on your suggestions .
UPDATE: