test_doc_examples.py: initialize examples_path. #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While trying to package the Python nixio module in Debian, most tests from test_doc_examples.py are failing with the following error: def handle_lif(self): > lif_path = Path.joinpath(self.examples_path, "lif.py") E AttributeError: 'TestDocumentationExamples' object has no attribute 'examples_path' This looks to be caused by missing initialisation of the examples_path attribute of the TestDocumentationExamples class. Initialising the attribute with the path to the documentation from the root of the sources corrects the issue. Signed-off-by: Étienne Mollier <emollier@debian.org>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #538 +/- ##
==========================================
+ Coverage 81.36% 81.38% +0.01%
==========================================
Files 81 81
Lines 10825 10828 +3
==========================================
+ Hits 8808 8812 +4
+ Misses 2017 2016 -1 ☔ View full report in Codecov by Sentry. |
jgrewe
approved these changes
Feb 18, 2024
|
Thank you @emollier for packaging and fixing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to package the Python nixio module in Debian, most tests from test_doc_examples.py are failing with the following error:
This looks to be caused by missing initialisation of the examples_path attribute of the TestDocumentationExamples class. Initialising the attribute with the path to the documentation from the root of the sources corrects the issue.