weston-init: Fix RDP support #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The modification of the weston.ini command line necessary for RDP
support is missing. The problem is the weston.ini template contains
`@bindir@`, while the sed operation for the modification contains
`${bindir}`.
Fix the problem by moving the replacement of `@bindir@` to the top of
the function `do_install:append()`.
Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
|
Thanks, @otavio. Can you backport to scarthgap? |
|
Backport failed for Please cherry-pick the changes locally. git fetch origin scarthgap
git worktree add -d .worktree/backport-1898-to-scarthgap origin/scarthgap
cd .worktree/backport-1898-to-scarthgap
git checkout -b backport-1898-to-scarthgap
ancref=$(git merge-base e4a09a4c5a1a10ec0ed96facaa9a8b1a2f506d7b 1963104c4ad7367686c910c70a07cbc7df3cd6c5)
git cherry-pick -x $ancref..1963104c4ad7367686c910c70a07cbc7df3cd6c5 |
|
It seems it does not apply cleanly. Could you prepare the backport manually? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modification of the weston.ini command line necessary for RDP support is missing. The problem is the weston.ini template contains
@bindir@, while the sed operation for the modification contains${bindir}.Fix the problem by moving the replacement of
@bindir@to the top of the functiondo_install:append().