Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide page info on beforeSlide and afterSlide callbacks #1070

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

sindras
Copy link
Contributor

@sindras sindras commented Sep 8, 2024

Description

Provide page information on beforeSlide and afterSlide callbacks.
This was supported in previous nuka-carousel versions. For example - codesandbox.
It will be useful for developers to track user's interactions with the carousel.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Storybook

Copy link

changeset-bot bot commented Sep 8, 2024

🦋 Changeset detected

Latest commit: fc30468

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
nuka-carousel Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuka-carousel-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 7:19pm

@carbonrobot
Copy link
Contributor

Thanks for the PR! Apologies for the delay, I was not getting notifications from this repo.

@carbonrobot carbonrobot merged commit de9cfbb into FormidableLabs:main Oct 7, 2024
3 of 4 checks passed
@github-actions github-actions bot mentioned this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants