Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(capacitor): ⬆️ upgrade for capacitor v5 #20

Merged
merged 4 commits into from
Feb 26, 2024
Merged

build(capacitor): ⬆️ upgrade for capacitor v5 #20

merged 4 commits into from
Feb 26, 2024

Conversation

eljass
Copy link
Member

@eljass eljass commented May 6, 2023

Description

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@mrozema
Copy link

mrozema commented Nov 30, 2023

Is this PR ready to be merged? I was hoping to use your fork of capacitor-intercom because the capacitor-community version is basically unmaintained, but this v5 update is critical to get updated. Thanks!

@eljass
Copy link
Member Author

eljass commented Feb 14, 2024

@mrozema sorry to get back to you so late. We haven't yet updated into v5, but will do so in next week and upgrade this plugin as well.

@eljass eljass marked this pull request as ready for review February 26, 2024 13:09
@eljass eljass merged commit 8913ddb into main Feb 26, 2024
@eljass eljass deleted the 5-0-0 branch February 26, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

updateUnreadCount notification object is nil
2 participants