Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mup: add Source Address to Type 1 ST Route #1193

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

takehaya
Copy link
Contributor

This patch adds Source Address to Type 1 ST Route as defined in draft-mpmz-bess-mup-safi-03.
See https://datatracker.ietf.org/doc/html/draft-mpmz-bess-mup-safi-03#section-3.1.3

@thomas-mangin
Copy link
Member

Very nice. Could I please ask for a separate test rather than extending the current one.

@thomas-mangin
Copy link
Member

Thank you for your work, if you can please update the PR with the suggested changes, I will then happily merge.

@takehaya
Copy link
Contributor Author

@thomas-mangin san Thank you for your kind review!

Very nice. Could I please ask for a separate test rather than extending the current one.

What tests does this expect to add?I would like to know if you would like 🙏

@thomas-mangin
Copy link
Member

You are welcome.

The test you wrote is good but it is using an existing file. If you create a new configuration and test files instead, it keeps the new test separate.

The configuration file needs to be created in etc/exabgp and a .ci and .msg file created in qa/encoding. qa/bin/functional can be used to run the new test.

@takehaya
Copy link
Contributor Author

thanks comment :)
i try fixed that because your kind feedback. pls continue review 🙏

@thomas-mangin thomas-mangin merged commit 14dd27a into Exa-Networks:main Jan 9, 2024
5 checks passed
@takehaya
Copy link
Contributor Author

takehaya commented Jan 9, 2024

@thomas-mangin -san thanks for your review! 🙏

@takehaya takehaya deleted the mup_st1_update_v3 branch January 9, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants