Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a generic ENV name to force build #38

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Use a generic ENV name to force build #38

merged 1 commit into from
Sep 11, 2023

Conversation

feld
Copy link
Contributor

@feld feld commented Aug 25, 2023

I'm trying to get all the Rustler libs I encounter on a daily basis to share the same ENV to force the build so each library doesn't need its own ENV. It would be nice if this became a common convention among Rustler libraries....

@feld
Copy link
Contributor Author

feld commented Aug 25, 2023

see also: ayrat555/ex_secp256k1#20

@tzumby
Copy link
Collaborator

tzumby commented Aug 26, 2023

Thanks @feld, I kicked off the CI

@tzumby
Copy link
Collaborator

tzumby commented Aug 27, 2023

Hey @feld, thanks for the PR, do you mind updating the GH actions to match the new env var ? There's a few CI builds that are failing as well :)

@tzumby tzumby merged commit 06473b0 into ExWeb3:main Sep 11, 2023
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants