Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing Moq dep in TeamChat tests #299

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

flaeri
Copy link
Contributor

@flaeri flaeri commented Sep 29, 2024

Adding Moq to the TeamChatModule resolves the issue I had on windows where I could not manage to get dotnet to resolve the and install the dependency.

Previously, if I ran dotnet list package inside of tests\Modules\TeamChatModule.Tests , Moq would be missing. With this change, it is now present:

Project 'TeamChatModule.Tests' has the following package references
   [net8.0]:
   Top-level Package                Requested   Resolved
   > coverlet.collector             6.0.0       6.0.0
   > Microsoft.NET.Test.Sdk         17.6.0      17.6.0
   > Moq                            4.20.70     4.20.70
   > xunit                          2.4.2       2.4.2
   > xunit.runner.visualstudio      2.4.5       2.4.5

The Moq specific build error I got on windows is also gone.

Build FAILED.

C:\repos\EvoSC-sharp\tests\Modules\TeamChatModule.Tests\Middlewares\TeamChatMiddlewareTests.cs(9,7): error CS0246: The type or namespace name 'Moq' could not be found (are you missing a using directive or an
assembly reference?) [C:\repos\EvoSC-sharp\tests\Modules\TeamChatModule.Tests\TeamChatModule.Tests.csproj]

I have not increased the versions in EvoSC.csproj or the README.md, as it did not make sense to me to do, nor did I find any version numbers to bump that made sense to bump.

@flaeri flaeri force-pushed the fix-moq-tests branch 2 times, most recently from 2bec6b6 to 9470bb7 Compare September 29, 2024 15:05
Copy link

sonarcloud bot commented Sep 29, 2024

@araszka araszka merged commit 3d68f3c into EvoEsports:master Sep 29, 2024
2 checks passed
@flaeri flaeri deleted the fix-moq-tests branch September 29, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants