Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Go client testing #152

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

w1am
Copy link
Contributor

@w1am w1am commented Oct 13, 2023

Changed: I've refactored parts of the code to allow tests to run without dependencies on functions that create the DB client.

  • Added a Makefile to execute SingleNode, SecureNode, and ClusterNode tests.
  • Toggle between secure and insecure modes by passing an environment variable.

Todo

  • Must change git branch rules status checks

@linear
Copy link

linear bot commented Oct 13, 2023

@w1am w1am force-pushed the w1am/dev-140-improve-golang-client-testing branch 8 times, most recently from 547100b to bbfc4ae Compare October 16, 2023 07:15
@w1am w1am requested a review from cdevarenne October 16, 2023 07:36
@w1am w1am force-pushed the w1am/dev-140-improve-golang-client-testing branch from bbfc4ae to 11c3a6b Compare October 16, 2023 07:39
- Updated the docker-compose.yml file to ensure the es-gencert-cli command is split over multiple lines for better readability without affecting its execution.
- Refactor codes that create the test containers to allow for running
  secure and insecure tests
- Add a Makefile to run single, secure and cluster test
- Add workflow for running tests separately
@w1am w1am force-pushed the w1am/dev-140-improve-golang-client-testing branch from 11c3a6b to 42d9cac Compare October 20, 2023 14:34
Copy link
Member

@YoEight YoEight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid work

@YoEight YoEight merged commit fd2fa52 into master Oct 20, 2023
25 checks passed
@YoEight YoEight deleted the w1am/dev-140-improve-golang-client-testing branch October 20, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants