Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add map components vite oauth sample #531

Merged
merged 18 commits into from
Sep 6, 2024

Conversation

manugadde
Copy link
Collaborator

@manugadde manugadde commented Aug 28, 2024

Description

Adds a new sample to the component-samples that demonstrates how to implement OAuth authentication with ArcGIS map components using a Vite-based project. The sample showcases how to securely authenticate users with ArcGIS Online and display secured web map with components.

Key additions:

  • Directory Structure: component-samples/components-oauth/
    • Vite Project: Utilizes Vite as the build tool.
    • OAuth Implementation: Demonstrates the setup of OAuth 2.0 authentication with ArcGIS Online.
    • Map Components Usage: Integrates with ArcGIS map components to display a secured web map post-authentication.
    • README.md: Instructions on how to set up and run the sample.
    • package.json: Necessary scripts and dependencies.
  • Zip file to download the directory: zips/map-components-ouath-sample-vite.zip.

How to Test:

  • Install the dependencies using npm install.
  • Build the project with npm run build and run the development server with npm run dev.
  • Follow the instructions in the README.md to configure your OAuth application and test the authentication flow with ArcGIS map components.

Copy link
Member

@andygup andygup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a few small things!

component-samples/components-oauth/README.md Outdated Show resolved Hide resolved
component-samples/components-oauth/package.json Outdated Show resolved Hide resolved
@manugadde manugadde requested review from dasa and andygup August 29, 2024 17:58
Copy link
Collaborator

@odoe odoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

component-samples/components-oauth/vite.config.js Outdated Show resolved Hide resolved
Copy link
Member

@dasa dasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 just have some nitpicks and questions.

component-samples/components-oauth/main.js Outdated Show resolved Hide resolved
component-samples/components-oauth/index.html Show resolved Hide resolved
component-samples/components-oauth/main.js Outdated Show resolved Hide resolved
component-samples/components-oauth/styles.css Outdated Show resolved Hide resolved
component-samples/components-oauth/main.js Outdated Show resolved Hide resolved
component-samples/components-oauth/main.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@odoe odoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folder needs a .gitignore. I thought there was a root one, but because of cli tooling, each app folder uses it's own.

@manugadde manugadde requested a review from odoe August 30, 2024 19:21
Copy link
Member

@andygup andygup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@manugadde manugadde merged commit baa87a3 into main Sep 6, 2024
1 check passed
@manugadde manugadde deleted the manoja/add-components-oauth-sample branch September 6, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants