Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ESM CDN): update to use importmap #525

Merged
merged 1 commit into from
Jul 23, 2024
Merged

chore(ESM CDN): update to use importmap #525

merged 1 commit into from
Jul 23, 2024

Conversation

andygup
Copy link
Member

@andygup andygup commented Jul 23, 2024

Update the sample to use the importmap pattern for better coding aesthetics.

@andygup andygup added the draft Pull requests that are a work in progress label Jul 23, 2024
@andygup andygup requested review from odoe and dasa July 23, 2024 22:53
dasa
dasa approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@dasa dasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@andygup andygup merged commit 097b586 into main Jul 23, 2024
2 checks passed
@andygup andygup deleted the esm-cdn-importmap branch July 23, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasa dasa dasa approved these changes

@odoe odoe Awaiting requested review from odoe

Assignees
No one assigned
Labels
draft Pull requests that are a work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andygup @dasa