Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update README and CONTRIBUTING #486

Merged
merged 3 commits into from
Sep 21, 2023
Merged

chore: update README and CONTRIBUTING #486

merged 3 commits into from
Sep 21, 2023

Conversation

andygup
Copy link
Member

@andygup andygup commented Sep 20, 2023

This PR updates the main README and CONTRIBUTING files:

  • Reorganize and reword
  • Include a TOC for the ESM samples
  • Make section headers more descriptive
  • Add additional context and clarifications, where needed

/cc @bsvensson

@andygup andygup requested review from odoe and dasa September 20, 2023 22:35
dasa
dasa requested changes Sep 20, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
andygup and others added 2 commits September 20, 2023 17:43
@andygup @dasa
Update CONTRIBUTING.md
c770a95 
Co-authored-by: Dasa Paddock <dpaddock@esri.com>
@andygup @dasa
Update README.md
32598b8 
Co-authored-by: Dasa Paddock <dpaddock@esri.com>
dasa
dasa approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@dasa dasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

odoe
odoe approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@odoe odoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@andygup andygup merged commit 6421bb2 into main Sep 21, 2023
1 check passed
@andygup andygup deleted the create-toc branch September 21, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odoe odoe odoe approved these changes

@dasa dasa dasa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andygup @odoe @dasa