Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(jsapi-node): update readme #485

Merged
merged 3 commits into from
Sep 19, 2023
Merged

chore(jsapi-node): update readme #485

merged 3 commits into from
Sep 19, 2023

Conversation

andygup
Copy link
Member

@andygup andygup commented Sep 19, 2023 •
edited
Loading

This PR contains:

  • Update wording to reflect that version 14 functionality is no longer supported.
  • Clarify when transpiling to CJS is required.
  • Reorganize the directory structure so that the .mjs examples aren't separated out anymore.

@andygup andygup requested review from odoe and dasa September 19, 2023 00:05
dasa
dasa approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@dasa dasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@andygup andygup merged commit d62a3cd into main Sep 19, 2023
1 check passed
@andygup andygup deleted the jsapi-node-update-readme branch September 19, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odoe odoe odoe approved these changes

@dasa dasa dasa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andygup @odoe @dasa