Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] Add tiled layer as basemap #527

Merged
merged 5 commits into from
Oct 22, 2024
Merged

Conversation

CalebRas
Copy link
Collaborator

Description

This PR implements Add tiled layer as basemap in Edit and Manage Data category.
URL to README: Add tiled layer as basemap

Linked Issue(s)

  • swift/issues/6215

How To Test

  • Open the sample to see the basemap tiled layer.

Screenshots

add-tiled-layer-as-basemap

@CalebRas CalebRas self-assigned this Oct 21, 2024
@CalebRas
Copy link
Collaborator Author

The iOS implementation has a button to view the other tile package files in the bundle and documents. This was not part of the design, so I did not implement this. Let me know if you think it is needed.

@CalebRas CalebRas requested review from a team, pgruenler and njarecha and removed request for a team October 21, 2024 17:41
njarecha
njarecha previously approved these changes Oct 21, 2024
Copy link
Contributor

@njarecha njarecha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@pgruenler pgruenler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one suggestion.

Shared/Samples/Add tiled layer as basemap/README.md Outdated Show resolved Hide resolved
Co-authored-by: Phil Gruenler <pgruenler@esri.com>
@CalebRas
Copy link
Collaborator Author

Thank you both!

@CalebRas CalebRas merged commit 83e4a2b into v.next Oct 22, 2024
1 check passed
@CalebRas CalebRas deleted the Caleb/New-AddTiledLayerAsBasemap branch October 22, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants