Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Snap settings build errors #523

Merged
merged 2 commits into from
Oct 17, 2024
Merged

[Fix] Snap settings build errors #523

merged 2 commits into from
Oct 17, 2024

Conversation

CalebRas
Copy link
Collaborator

Description

This PR fixes build errors with some snap settings boolean names that were change during a recent audit.

Linked Issue(s)

How To Test

  • Ensure the project builds using the latest swift daily.

@CalebRas CalebRas self-assigned this Oct 17, 2024
yo1995
yo1995 reviewed Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@yo1995 yo1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the README as well? Thanks.

Shared/Samples/Snap geometry edits/SnapGeometryEditsView.SnapSettingsView.swift Outdated Show resolved Hide resolved
Shared/Samples/Snap geometry edits/SnapGeometryEditsView.SnapSettingsView.swift Outdated Show resolved Hide resolved
@CalebRas CalebRas requested a review from yo1995 October 17, 2024 20:43
@CalebRas CalebRas merged commit 2f34ab4 into v.next Oct 17, 2024
1 check passed
@CalebRas CalebRas deleted the Caleb/Fix-SnapSettingsBuildErrors branch October 17, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yo1995 yo1995 yo1995 approved these changes

@zkline101 zkline101 zkline101 approved these changes

Assignees

@CalebRas CalebRas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CalebRas @yo1995 @zkline101