Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expedition calculator #501

Merged
merged 4 commits into from
Sep 29, 2024
Merged

Expedition calculator #501

merged 4 commits into from
Sep 29, 2024

Conversation

myangelkamikaze
Copy link
Member

No description provided.

@myangelkamikaze myangelkamikaze marked this pull request as ready for review September 29, 2024 04:09
@Jebzou
Copy link
Member

Jebzou commented Sep 29, 2024

Everything looks fine.
Maybe add a max value for sparkled count (6) and add max for Flagship level (ExpTable.ShipMaximumLevel might need to be moved to the Type project) ?

Copy link

sonarcloud bot commented Sep 29, 2024

@myangelkamikaze
Copy link
Member Author

Everything looks fine. Maybe add a max value for sparkled count (6) and add max for Flagship level (ExpTable.ShipMaximumLevel might need to be moved to the Type project) ?

Added max for sparkled boats. I'd just keep the level without a max value, we have it that way in ship encyclopedia too.

@myangelkamikaze myangelkamikaze merged commit be8e1dd into main Sep 29, 2024
2 checks passed
@myangelkamikaze myangelkamikaze deleted the ExpeditionCalculator branch September 29, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants