Router types #5263
Merged
Router types #5263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
force-pushed
the
william/router-types
branch
2 times, most recently
from
afd92b4
to
a0234f7
Compare
peachbits
approved these changes
Sep 21, 2024
| navigation: NavigationProp<'pluginView' | 'pluginViewBuy' | 'pluginViewSell'> | ||
|
|
||
| // Work around an extremely strange & hard-to-debug type error: | ||
| route: any // RouteProp<'pluginView' | 'pluginViewBuy' | 'pluginViewSell'> |
There was a problem hiding this comment.
Weird. I tried to debug as well but couldn't resolve it.
swansontec
force-pushed
the
william/router-types
branch
from
a0234f7
to
2a14ba0
Compare
Since there is only one scene in this stack, why do we even need it?
With this change, we now verify that the scenes inside a router match what the router expects. This also gives us type checking for when we navigate to a scene nested within a router. Unfortunately, we still have the `NavigationBase` type in the app which doesn't properly distinguish between the different types of navigation objects and their varying capabilities. This needs to be fixed.
swansontec
force-pushed
the
william/router-types
branch
from
2a14ba0
to
2469445
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: