Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use value directly in placeholderTextColor #4694

Closed
wants to merge 1 commit into from

Conversation

peachbits
Copy link
Contributor

@peachbits peachbits commented Jan 9, 2024


@paullinator paullinator force-pushed the matthew/fixSimpleTextInputAndroidCrash branch from dcc54fa to fe51352 Compare January 10, 2024 00:39
Copy link
Contributor

@samholmes samholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect that passing the shared value to this property would allow for reanimated to animate the InputText property. If we pass the value directly, we get no animation behavior. If we don't want animation behavior, then the correct fixed is to change the variable from a SharedValue<string> to string

@paullinator
Copy link
Member

Ack. ok then a different fix is required

@samholmes
Copy link
Contributor

This PR commit the issue with placeholder color animation: 7c1eab0

@samholmes samholmes closed this Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants