Correctly tag tokenApproval actionType in getTxActionDisplayInfo

EdgeApp · Sep 23, 2024 · 9e90e1c · 9e90e1c
1 parent 4eb8156
commit 9e90e1c
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 - added: Buy conversion tracking for Moonpay
 - added: Error tracking for failure to report conversions to referral server
 - changed: Remove whitespaces from custom token contract address input
+- fixed: Correctly tag `tokenApproval` `actionType` in  `getTxActionDisplayInfo`
 - fixed: Clear previous swap errors when new amounts are entered or swap assets are changed in `SwapCreateScene`
 - fixed: AddressTile2 touchable area states
 - fixed: Cases where it was possible to create duplicate custom tokens

diff --git a/src/actions/CategoriesActions.ts b/src/actions/CategoriesActions.ts
@@ -324,6 +324,8 @@ export const getTxActionDisplayInfo = (tx: EdgeTransaction, account: EdgeAccount
     const { assetActionType } = assetAct
     payeeText = TX_ACTION_LABEL_MAP[assetActionType]
 
+    let unsupported = false
+
     switch (actionType) {
       case 'swap': {
         iconPluginId = action.swapInfo.pluginId
@@ -379,7 +381,7 @@ export const getTxActionDisplayInfo = (tx: EdgeTransaction, account: EdgeAccount
             break
           }
           default:
-            console.error(`Unsupported EdgeTxAction assetAction:assetActionType: '${assetAction}:${assetActionType}'`)
+            unsupported = true
         }
         break
       }
@@ -450,7 +452,7 @@ export const getTxActionDisplayInfo = (tx: EdgeTransaction, account: EdgeAccount
           }
 
           default:
-            console.error(`Unsupported EdgeTxAction assetAction:assetActionType: '${assetAction}:${assetActionType}'`)
+            unsupported = true
         }
         break
       }
@@ -479,13 +481,26 @@ export const getTxActionDisplayInfo = (tx: EdgeTransaction, account: EdgeAccount
             break
           }
           default:
-            console.error(`Unsupported EdgeTxAction assetAction:assetActionType: '${assetAction}:${assetActionType}'`)
+            unsupported = true
+        }
+        break
+      }
+      case 'tokenApproval': {
+        switch (assetActionType) {
+          case 'tokenApproval': {
+            edgeCategory = { category: 'expense', subcategory: lstrings.wc_smartcontract_network_fee }
+            break
+          }
+          default:
+            unsupported = true
         }
         break
       }
       default:
-        console.error(`Unsupported EdgeTxAction assetAction: '${assetAction}'`)
+        unsupported = true
     }
+
+    if (unsupported) console.error(`Unsupported EdgeTxAction assetAction:assetActionType '${assetAction}:${assetActionType}'`)
   }
   const savedData: EdgeMetadata = {
     name: payeeText,