[bug] Fix bad JSON property for estimated delivery date (#506)

- Fix bad JSON property for estimated delivery date - Update unit tests to verify correct JSON deserialization of time in transit data
EasyPost · Aug 17, 2023 · eb55628 · eb55628
1 parent 9b25c14
commit eb55628
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/EasyPost.Tests/ServicesTests/ShipmentServiceTest.cs b/EasyPost.Tests/ServicesTests/ShipmentServiceTest.cs
@@ -153,7 +153,8 @@ public async Task TestAllParameterHandOff()
             const bool includeChildren = true;
             const bool purchased = false;
 
-            Dictionary<string, object> filters = new Dictionary<string, object> {
+            Dictionary<string, object> filters = new Dictionary<string, object>
+            {
                 { "include_children", includeChildren },
                 { "purchased", purchased },
             };
@@ -208,7 +209,8 @@ public async Task TestGetNextPageParameterHandOff()
             const bool includeChildren = true;
             const bool purchased = false;
 
-            Dictionary<string, object> filters = new Dictionary<string, object> {
+            Dictionary<string, object> filters = new Dictionary<string, object>
+            {
                 { "include_children", includeChildren },
                 { "purchased", purchased },
             };
@@ -598,6 +600,9 @@ public async Task TestRetrieveEstimatedDeliveryDates()
             foreach (var rate in ratesWithEstimatedDeliveryDates)
             {
                 Assert.NotNull(rate.EasyPostTimeInTransitData);
+                Assert.NotNull(rate.EasyPostTimeInTransitData.EasyPostEstimatedDeliveryDate);
+                Assert.NotNull(rate.EasyPostTimeInTransitData.DaysInTransit);
+                Assert.NotNull(rate.EasyPostTimeInTransitData.PlannedShipDate);
             }
         }
 

diff --git a/EasyPost.Tests/ServicesTests/WithParameters/ShipmentServiceTest.cs b/EasyPost.Tests/ServicesTests/WithParameters/ShipmentServiceTest.cs
@@ -417,6 +417,9 @@ public async Task TestRetrieveEstimatedDeliveryDates()
             foreach (var rate in ratesWithEstimatedDeliveryDates)
             {
                 Assert.NotNull(rate.EasyPostTimeInTransitData);
+                Assert.NotNull(rate.EasyPostTimeInTransitData.EasyPostEstimatedDeliveryDate);
+                Assert.NotNull(rate.EasyPostTimeInTransitData.DaysInTransit);
+                Assert.NotNull(rate.EasyPostTimeInTransitData.PlannedShipDate);
             }
         }
 

diff --git a/EasyPost/Models/API/RateWithEstimatedDeliveryDate.cs b/EasyPost/Models/API/RateWithEstimatedDeliveryDate.cs
@@ -23,7 +23,6 @@ public class RateWithEstimatedDeliveryDate
         public TimeInTransitDetails? EasyPostTimeInTransitData { get; set; }
 
         #endregion
-
     }
 
     /// <summary>
@@ -42,8 +41,8 @@ public class TimeInTransitDetails
         /// <summary>
         ///     EasyPost's estimated delivery date for the associated <see cref="RateWithEstimatedDeliveryDate"/>.
         /// </summary>
-        [JsonProperty("easypost_time_in_transit_data")]
-        public string? EasyPostEstimatedDeliveryDate { get; set; }
+        [JsonProperty("easypost_estimated_delivery_date")]
+        public DateTime? EasyPostEstimatedDeliveryDate { get; set; }
 
         /// <summary>
         ///     The planned departure date for the shipment.
@@ -52,6 +51,5 @@ public class TimeInTransitDetails
         public DateTime? PlannedShipDate { get; set; }
 
         #endregion
-
     }
 }