Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set eflx_building_lun to spval properly #2806

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

olyson
Copy link
Contributor

@olyson olyson commented Oct 2, 2024

Description of changes

Set eflx_building_lun to spval properly

Specific notes

Contributors other than yourself, if any: @cathyxinchangli

CTSM Issues Fixed (include github issue #):

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any:
Ran aux_clm.
Unexpected failures:

FAIL ERI_D.ne30pg3_t232.I1850Clm60BgcCropG.derecho_intel.clm-clm60cam7LndTuningModeLDust COMPARE_base_hybrid
FAIL ERI_D.ne30pg3_t232.I1850Clm60BgcCropG.derecho_intel.clm-clm60cam7LndTuningModeLDust COMPARE_base_rest

These failed because there was one variable not bfb, DPFCT_ROCK.
Unsure why that would be different.

Copy link
Contributor

@slevis-lmwg slevis-lmwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olyson I will approve preemptively, though I know that you're investigating a strange test-failure.

src/biogeophys/EnergyFluxType.F90 Show resolved Hide resolved
@slevis-lmwg slevis-lmwg added the bfb bit-for-bit label Oct 2, 2024
@olyson
Copy link
Contributor Author

olyson commented Oct 3, 2024

I tried that test above with ctsm5.3.002 and it passed as expected. I then ran it 3 times with my branch and all passed. So must have been some kind of glitch.

@slevis-lmwg slevis-lmwg self-assigned this Oct 7, 2024
@samsrabin samsrabin changed the title Fix issue #2793 Set eflx_building_lun to spval properly Oct 8, 2024
@olyson
Copy link
Contributor Author

olyson commented Oct 8, 2024

Testing after rebasing to b4b-dev:
"Unexpected" failures on Izumi:
FAIL ERI_D_Ld9_P48x1.f10_f10_mg37.I2000Clm50BgcCru.izumi_nag.clm-reduceOutput RUN
This is due to floating underflow (#2800 )
PEND SMS_Ld10_D_Mmpi-serial.CLM_USRDAT.I1PtClm60Bgc.izumi_nag.clm-NEON-MOAB--clm-PRISM SHAREDLIB_BUILD
This is due to (Issue #2801 ):

err=ERROR : CLM build-namelist::CLMBuildNamelist::add_default() : No default value found for fsurdat.
            Are defaults provided for this resolution and land mask?'

"Unexpected" failures on Derecho:
FAIL SMS_Ld2_D_PS.f09_g17.I1850Clm60BgcCropCmip6.derecho_intel.clm-basic_interp BASELINE ctsm5.3.002: ERROR BFAIL baseline directory '/glade/campaign/cgd/tss/ctsm_baselines/ctsm5.3.002/SMS_Ld2_D_PS.f09_g17.I1850Clm60BgcCropCmip6.derecho_intel.clm-basic_interp' does not exist

FAIL SMS_D_Ld1.ne30pg3_t232.I1850Clm50BgcSpinup.derecho_intel.clm-cplhist--clm-matrixcnOn BASELINE ctsm5.3.002: ERROR BFAIL baseline directory '/glade/campaign/cgd/tss/ctsm_baselines/ctsm5.3.002/SMS_D_Ld1.ne30pg3_t232.I1850Clm50BgcSpinup.derecho_intel.clm-cplhist--clm-matrixcnOn' does not exist

FAIL SMS_D_Ld1.ne30pg3_t232.I1850Clm50BgcSpinup.derecho_intel.clm-cplhist BASELINE ctsm5.3.002: ERROR BFAIL baseline directory '/glade/campaign/cgd/tss/ctsm_baselines/ctsm5.3.002/SMS_D_Ld1.ne30pg3_t232.I1850Clm50BgcSpinup.derecho_intel.clm-cplhist' does not exist

FAIL ERS_Ly3.f10_f10_mg37.I1850Clm60BgcCropCmip6.derecho_intel.clm-basic BASELINE ctsm5.3.002: ERROR BFAIL baseline directory '/glade/campaign/cgd/tss/ctsm_baselines/ctsm5.3.002/ERS_Ly3.f10_f10_mg37.I1850Clm60BgcCropCmip6.derecho_intel.clm-basic' does not exist

FAIL SMS_Lm1.f10_f10_mg37.I1850Clm60BgcCropCmip6waccm.derecho_gnu.clm-basic BASELINE ctsm5.3.002: ERROR BFAIL baseline directory '/glade/campaign/cgd/tss/ctsm_baselines/ctsm5.3.002/SMS_Lm1.f10_f10_mg37.I1850Clm60BgcCropCmip6waccm.derecho_gnu.clm-basic' does not exist

PEND SMS_Ld10_D_Mmpi-serial.CLM_USRDAT.I1PtClm60Bgc.derecho_gnu.clm-NEON-MOAB--clm-PRISM SHAREDLIB_BUILD (UNEXPECTED: expected FAIL)
This is due to (Issue #2801 ):

err=ERROR : CLM build-namelist::CLMBuildNamelist::add_default() : No default value found for fsurdat.
            Are defaults provided for this resolution and land mask?'

Since none of these failures appear to be related to this PR, I'm merging this into b4b-dev

@olyson olyson merged commit 86fbf18 into ESCOMP:b4b-dev Oct 8, 2024
2 checks passed
@samsrabin samsrabin mentioned this pull request Oct 10, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants