Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

build.sh: switch from CMAKE_FRAMEWORK_PATH to CMAKE_MODULE_PATH #503

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

pnx
Copy link

@pnx pnx commented Jul 16, 2020

Change Description

CMAKE_FRAMEWORK_PATH is bad as it's read by cmake but it is not available in cmake scripts.
Also according to the documentation this variable should contain path to OS X frameworks.

CMAKE_MODULE_PATH is the right way to go.

By adding this code to CMakeLists.txt (line 78 in this case):

message(FATAL_ERROR "${CMAKE_FRAMEWORK_PATH}")

And run:

$ export CMAKE_FRAMEWORK_PATH=/usr/opt/eosio.cdt/1.7
$ cmake ..

You get the following output:

-- The C compiler identification is GNU 7.5.0
-- The CXX compiler identification is GNU 7.5.0
...
-- Building eosio.contracts v1.9.0-rc1
-- Using eosio.cdt version 1.7.0
CMake Error at CMakeLists.txt:78 (message):


-- Configuring incomplete, errors occurred!

Deployment Changes

  • Deployment Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@nksanthosh nksanthosh requested review from tbfleming, spoonincode and nksanthosh and removed request for tbfleming September 18, 2020 14:54
Copy link

@nksanthosh nksanthosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please use CMAKE_PREFIX_PATH instead and resubmit? Thank you

…_PATH, instead pass them to cmake in CMAKE_PREFIX_PATH

CMAKE_FRAMEWORK_PATH is bad as it's read by cmake but it is not available in cmake scripts.
Also according to the documentation this variable should contain path to OS X frameworks.
@pnx
Copy link
Author

pnx commented Nov 4, 2020

Can you please use CMAKE_PREFIX_PATH instead and resubmit? Thank you

Fixed and pushed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants