Use ChunkedBase 0.3

Drvi · Jul 19, 2023 · 20c7625 · 20c7625
1 parent f80b4b1
commit 20c7625
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/Project.toml b/Project.toml
@@ -10,7 +10,7 @@ SentinelArrays = "91c51154-3ec4-41a3-a24f-3f23e20d615c"
 SnoopPrecompile = "66db9d55-30c0-4569-8b51-7e840670fc0c"
 
 [compat]
-ChunkedBase = "0.2"
+ChunkedBase = "0.3"
 JSON3 = "1"
 SentinelArrays = "1"
 SnoopPrecompile = "1"

diff --git a/src/ChunkedJSONL.jl b/src/ChunkedJSONL.jl
@@ -52,7 +52,7 @@ function parse_file(
 
     lexer = Lexer(io, nothing, newline)
     ChunkedBase.initial_lex!(lexer, chunking_ctx, bytes_read_in)
-    ChunkedBase.skip_rows_init!(lexer, chunking_ctx, skipto)
+    ChunkedBase.skip_rows_init!(lexer, chunking_ctx, skipto, ignoreemptyrows)
 
     nrows = length(chunking_ctx.newline_positions) - 1
     try

diff --git a/test/basic_tests.jl b/test/basic_tests.jl
@@ -854,12 +854,17 @@ end
         ctx = ValueExtractionContext()
         ChunkedJSONL.parse_file(IOBuffer("1\n2\n\n3\n4\n5"), ctx, _force=alg, buffersize=4, skipto=2, limit=2)
 
-        @test ctx.elements == [3]
+        @test ctx.elements == [3, 4]
+
+        ctx = ValueExtractionContext()
+        ChunkedJSONL.parse_file(IOBuffer("0\n1\n2\n\n3\n4\n5"), ctx, _force=alg, buffersize=4, skipto=2, limit=2)
+
+        @test ctx.elements == [2]
 
         ctx = ValueExtractionContext()
         ChunkedJSONL.parse_file(IOBuffer("1\n#\n#\n#\n2\n#\n3\n4\n5"), ctx, _force=alg, buffersize=4, skipto=2, limit=3, comment='#')
 
-        @test sort(ctx.elements) == [2,3]
+        @test sort(ctx.elements) == [2, 3]
     end
 end