feat(network-message): Use redis entirely to store messages #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves the handling of referenced messages in the network message commands. The changes include: - Use `getOriginalMessage` and `findOriginalMessage` functions to fetch the original message data, handling both original and broadcast messages. - Fetch the hub data directly from the original message data, avoiding additional database queries. - Use the `fetchHub` function to retrieve the hub data, ensuring it is available. - Update the `DeleteMessage` command to use the `broadcasts` property of the original message instead of the `broadcastMsgs` property. - Refactor the `NetworkReactionInteraction` class to use the original message data directly, instead of relying on the `broadcastedMessages` table. The goal of these changes is to improve the efficiency and reliability of the network message handling, reducing database queries and ensuring consistent data access.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the handling of referenced messages in the network message
commands. The changes include:
getOriginalMessageandfindOriginalMessagefunctions to fetch theoriginal message data, handling both original and broadcast messages.
additional database queries.
fetchHubfunction to retrieve the hub data, ensuring it isavailable.
DeleteMessagecommand to use thebroadcastsproperty of theoriginal message instead of the
broadcastMsgsproperty.NetworkReactionInteractionclass to use the original messagedata directly, instead of relying on the
broadcastedMessagestable.The goal of these changes is to improve the efficiency and reliability of the
network message handling, reducing database queries and ensuring consistent
data access.