Automatically log in Azure if needed #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorentClarret
force-pushed
the
florentclarret/az-authenticate
branch
from
818878b
to
ec3df73
Compare
FlorentClarret
commented
Jul 22, 2024
FlorentClarret
force-pushed
the
florentclarret/az-authenticate
branch
from
ec3df73
to
28cb84e
Compare
KevinFairise2
approved these changes
Jul 26, 2024
pducolin
approved these changes
Jul 26, 2024
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Azure's counterpart of #917. I know this is a hack but:
NewInteractiveBrowserCredentialfrom the azure SDK to get the token. Unfortunately I can't use it with the pulumi's SDK: Is there away to authenticate with an access token? pulumi/pulumi-azure-native#565The idea is to automatically run
az loginif needed so users don't have to wrap their commands on their side.Which scenarios this will impact?
Azure scenarios only! We currently don't have any
Motivation
Avoid asking people to manually run
az loginbefore running the tests. They might not know the tests is running in Azure, because it could be in AWS (or later in GCP)Additional Notes