-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add two tasks to create and destroy VM stacks in Azure #958
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add it to integration tests too?
Co-authored-by: pducolin <45568537+pducolin@users.noreply.github.com>
ae9f224
to
48a0f38
Compare
I commented the section to run integrations tests on Azure. We need https://github.com/DataDog/cloud-inventory/pull/20422 for this, it's currently broken and cloudops is having a look. I'll open a follow-up PR to address that. Merging this one so we can move on with the refactoring of the tasks |
/merge |
🚂 MergeQueue: waiting for PR to be ready This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
Co-authored-by: KevinFairise2 <kevin.fairise@datadoghq.com>
What does this PR do?
az.create-vm
andaz.destroy-vm
to create VMs with the Agent in Azure. They are currently very basic and do not have all the parameters the AWS counterpart has but we'll add them in future PRs to keep this PR readable.setup
task to include the new parameter for Azure. We have also a key parameter for AWS thsat could be merged in a follow-up PRcreate-vm
anddestroy-vm
tasks in favour ofaws.create-vm
andaws.destroy-vm
. The old commands still work. they print a deprecation message and redirect to the new versiondeploy
function as is, where we have a lot of AWS specific stuff. I did not want to refactor too much and I'll open a PR in the future to move them to the AWS-specific commandTo make it work, we need to have an ssh key to use for this instance. For instance:
I'll add documentation about this once this will be a bit more stable and usable for everyone. This parameter is not required unless you're trying to deploy a VM on Azure
Which scenarios this will impact?
Everyone who uses the
create-vm
ordestroy-vm
and people who want to deploy a VM in Azure.Motivation
The Azure sandbox is out!
Additional Notes
Co-authored with @KevinFairise2
https://datadoghq.atlassian.net/browse/ADXT-487