Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nodejs] fix tag_value endpoint and enable APISec path_params tests #3251

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

simon-id
Copy link
Member

@simon-id simon-id commented Oct 16, 2024

Motivation

The path_params test for API Security was never enabled. Because the endpoint was not correctly implemented.

Changes

Fix the endpoint, and enable the test.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@simon-id simon-id self-assigned this Oct 16, 2024
@simon-id simon-id marked this pull request as ready for review October 16, 2024 13:32
@simon-id simon-id requested review from a team as code owners October 16, 2024 13:32
Co-authored-by: Carles Capell <107924659+CarlesDD@users.noreply.github.com>
@simon-id simon-id enabled auto-merge (squash) October 16, 2024 13:58
@simon-id simon-id merged commit 9f29fe6 into main Oct 16, 2024
9 checks passed
@simon-id simon-id deleted the fix_node_apisec_pathparams branch October 16, 2024 14:05
mtoffl01 pushed a commit that referenced this pull request Oct 17, 2024
…3251)

Co-authored-by: Carles Capell <107924659+CarlesDD@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants