Add PHP to live debugger system tests #2792
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare system tests for live debugger in dd-trace-php version 1.4.
I've verified locally that these system tests pass with the artifact from https://output.circle-artifacts.com/output/job/59686ec3-ad57-47e9-8202-09fb9a298447/artifacts/0/dd-library-php-1.4.0+457f890a449fc458b3b2955d3952e56a129c3eae-aarch64-linux-gnu.tar.gz.
This PR fixes a couple mistakes in existing tests, adds a bit more debug logging to the PHP tracer outputs and makes the probes conform to the current debugging schema (PHP looks at the type rather than the name of the probe).
Note that, by design of the RC client in PHP, no probes are received if nothing is running. Hence there are calls to
await_probes.php
, which actively waits for the probes to be installed, and will also emit diagnostics, which the system-tests can interpret as signal of all probes having been successfully installed.Further, it's not trivial as in PHP to define routes with wildcards (either you say "all args after first slash are function args" or "route is always static". I've opted to replace a couple slashes in paths by underscores. Not just as nice, but works perfectly fine and is easier.
Reviewer checklist
[<language>]
, double-check that only<language>
is impacted by the changebuild-XXX-image
label is present