Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Dasharo Entry Subscription to Dasharo Pro Package #914

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

philipandag
Copy link
Contributor

Also change all occurences of DES.
Didn't change any filenames or links.
There were occurences where the DES was referenced as a former name of DPP. I have kept them.

Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
@miczyg1
Copy link
Contributor

miczyg1 commented Oct 10, 2024

@philipandag you may change the relevant links. For any links you change, simply add a redirect here: https://github.com/Dasharo/docs/pull/914/files#diff-98d0f806abc9af24e6a7c545d3d77e8f9ad57643e27211d7a7b896113e420ed2R90

Also I won't approve unless CI passes, we don't want broken links.

@philipandag
Copy link
Contributor Author

philipandag commented Oct 14, 2024

Also I won't approve unless CI passes, we don't want broken links.

All the "broken" links work fine when I go there manually. I guess it was some network issue?

Also updated mkdocs to use the new name and added a redirect from the
old name to the new one

Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
@philipandag
Copy link
Contributor Author

The broken links from before are not detected anymore, although there are still some broken links to a google spreadsheet showing test results for PC Engines test results in files which I haven't modified.

  1. docs/variants/pc_engines/releases_seabios.md: link to releases spreadsheet
## v24.05.00.01 - 2024-06-28

Test results for this release can be found
[here](https://docs.google.com/spreadsheets/d/1_uRhVo9eYeZONnelymonYp444zYHT_Q_qmJEJ8_XqJc/edit?usp=sharing).
  1. docs/variants/pc_engines/post-eol-fw-announcement.md:
Since February 2016, we have made [87 binary releases][3] for all PC Engines
hardware platforms from apu1 through famous apu2 up to apu7. We published over
[30k test results][4] from our automated testing framework. <<<< 30k test results is broken
  1. docs/variants/pc_engines/faq.md:
**Test Scope:**
While the exact test scope for the upcoming BIOS version is currently being
finalized, it will offer feature parity with version 4.19.0.1. The test scope
for version 4.19.0.1, which might give you an idea of what to expect, can be
found in this document: [Dasharo Test Scope Document](https://docs.google.com/spreadsheets/d/1_uRhVo9eYeZONnelymonYp444zYHT_Q_qmJEJ8_XqJc/edit#gid=0).

Was the spreadsheet moved somewhere else?

subscriber. If you have DPP subscription then do steps in
[How can I use my Dasharo Entry Subscription credentials](
[How can I use my Dasharo Pro Package credentials](
../osf-trivia-list/dts.md#how-can-i-use-my-dasharo-entry-subscription-credentials)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DES is left here in the link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -395,10 +394,9 @@ Please consider the following options depending on your situation:

DTS can be used to update Dasharo firmware. To achieve this, boot it on platform
with flashed Dasharo and choose option number `2`. You may see additional
information about available updates if you are not [Dasharo Entry
Subscription](https://docs.dasharo.com/ways-you-can-help-us/#become-a-dasharo-entry-subscription-subscriber)
information about available updates if you are not [Dasharo Pro Package](https://docs.dasharo.com/ways-you-can-help-us/#become-a-dasharo-entry-subscription-subscriber)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here DES is left here in the link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -128,6 +128,8 @@ plugins:
'variants/protectli_vp2410/recovery.md': 'unified/protectli/recovery.md#vp2410'
'variants/protectli_vp2420/recovery.md': 'unified/protectli/recovery.md#vp2420'

'osf-trivia-list/dasharo-entry-subscription.md': 'osf-trivia-list/dasharo-pro-package.md'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have changed more than one heading, this is obviously not enough

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, also the headings, not only files should be included here.

@philipandag philipandag force-pushed the dasharo-entry-subscription-name-update branch from ab89e91 to 5b987bf Compare October 14, 2024 08:31
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
@philipandag philipandag force-pushed the dasharo-entry-subscription-name-update branch from 5b987bf to 196f50a Compare October 14, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants