Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/2x2 event display #121

Merged
merged 70 commits into from
Aug 23, 2024
Merged

Feature/2x2 event display #121

merged 70 commits into from
Aug 23, 2024

Conversation

marjoleinvannuland
Copy link
Contributor

Web based event display for flow files

krwood
krwood approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@krwood krwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be consistent with other conventions inside ndlar_flow, can you rename the subdirectory event_display/2x2_flow to event_display/proto_nd_flow?

@marjoleinvannuland
Copy link
Contributor Author

Renamed the folder to interactive_event_display to be more descriptive of the contents. It allows plotting of single module data and 2x2 and minerva.

@marjoleinvannuland marjoleinvannuland force-pushed the feature/2x2-event-display branch 2 times, most recently from 0ae1b61 to 8306fa9 Compare June 28, 2024 13:50
@YifanC YifanC merged commit f9307b4 into develop Aug 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krwood krwood krwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marjoleinvannuland @krwood @YifanC