Add fuzzing harness #906
Merged
Add fuzzing harness #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathaniel-brough
force-pushed
the
dev
branch
from
aa03f63
to
7979b1f
Compare
|
I'm rather favorable to this effort, given the increased security coverage offered by oss-fuzz, note though that the current proposal (this PR) fails CI tests. |
Cyan4973
reviewed
Dec 26, 2023
Makefile
Outdated
| @@ -315,6 +316,12 @@ test-xxhsum-c: xxhsum | |||
| echo "00000000 test-expects-file-not-found" | ./xxhsum -c -; test $$? -eq 1 | |||
| @$(RM) .test.* | |||
|
|
|||
| LIB_FUZZING_ENGINE?="-fsanitize=fuzzer" | |||
| ifeq '' '$(findstring clang++,$(CXX))' | |||
There was a problem hiding this comment.
Is this ifeq correct ?
I thought it would require parenthesis
There was a problem hiding this comment.
Your probably right. Just fiddling with this to get it working.
nathaniel-brough
force-pushed
the
dev
branch
from
7979b1f
to
2b0824e
Compare
Great! Working on getting everything green, it's been a while since I've been working with Makefiles so I'm a little rusty. |
nathaniel-brough
force-pushed
the
dev
branch
from
2b0824e
to
530e662
Compare
Cyan4973
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.