feat: implement basic kinematics functionality of the helicity formalism #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove unused function.
Add doc strings to helicity formalism kinematics and the corrensponding test. Also fix all flake8 and pylint related issues.
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
==========================================
+ Coverage 82.45% 83.07% +0.62%
==========================================
Files 24 24
Lines 2542 2618 +76
==========================================
+ Hits 2096 2175 +79
+ Misses 446 443 -3
|
|
Failed job will be fixed by #42 |
redeboer
changed the title
redeboer
reviewed
Apr 27, 2020
redeboer
reviewed
Apr 27, 2020
redeboer
reviewed
Apr 27, 2020
redeboer
reviewed
Apr 27, 2020
redeboer
reviewed
Apr 27, 2020
redeboer
reviewed
Apr 27, 2020
redeboer
reviewed
Apr 27, 2020
|
Good work, also nicely documented! If this module is required to move on with the development, I'm happy to approve and discuss the bigger issues (final state ID and namespaces) separately. |
redeboer
pushed a commit
that referenced
this pull request
May 5, 2020
* feat: add helicity kinematics * test: add test for helicity angle calculation * refactor: adapt to new Kinematics interface * docs: add doc strings to helicity kinematics * ci: add doc/conf.py to blacklist of linters * docs: add `__eq__` to shown members of the API
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3
Note: Some functionality of the ComPWA kinematics is still missing #15, #38.